-
Notifications
You must be signed in to change notification settings - Fork 71
fix: make overlay display over backdrop, by appending overlay to body #165
Conversation
Fixes PolymerElements/paper-dialog#7 Fixes Polymer/polymer-starter-kit#154 Fixes (maybe) PolymerElements/paper-dialog#79 Fixes (maybe) PolymerElements/paper-dialog#44 Fixes (maybe) PolymerElements/paper-drawer-panel#122 Related to PolymerElements#72 Related to PolymerElements#86 Related to https://github.com/PolymerElements/iron-overlay-behavior/compare/backdrop-refit Fixes (maybe) PolymerElements/paper-dialog-behavior#78 Fixes PolymerElements/app-layout#155
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Hi @timblack1, the current proposal has several drawbacks, e.g. it breaks style encapsulation. Also, the fact that you reparent it will cause |
Does https://github.com/PolymerElements/iron-overlay-behavior/blob/master/iron-overlay-backdrop.html#L99 break style encapsulation too? That is the line which necessitates a fix like the one proposed here. |
Not really, as it is done if you explicitly call the method and if the element doesn't have a parent. I'm working on overcoming these stacking context related issues in the stacking-context branch. Happy to discuss the approach in a separate issue! |
I don't see an infinite loop in my manual testing of this proposed change. I look forward to seeing a good resolution of the problem. |
The PR with the proposal is this one #155 |
its works but its not a good way for solving problem, its like a hack dom, and maybe make problem with data binding, etc ... |
Fixes PolymerElements/paper-dialog#7
Fixes Polymer/polymer-starter-kit#154
Fixes (maybe) PolymerElements/paper-dialog#79
Fixes (maybe) PolymerElements/paper-dialog#44
Fixes (maybe) PolymerElements/paper-drawer-panel#122
Related to #72
Related to #86
Related to https://github.com/PolymerElements/iron-overlay-behavior/compare/backdrop-refit
Fixes (maybe) PolymerElements/paper-dialog-behavior#78
Fixes PolymerElements/app-layout#155