Use URLSearchParams for paramsObject #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cailyncodes
force-pushed
the
url-search-params
branch
from
e0976e3
to
37cd939
Compare
…o expect URLSearchParams objects Add utility methods for URLSearchParams: URLSearchParams don't have notions of equality defined in the spec, so we go through iterating over all entries checking for equality for testing purposes; Chrome (v60) currently doesn't support constructing URLSearchParams from objects, so add utility method to convert objects into arrays of pairs Update tests to expect URLSearchParams for search query: Tests that would normally expect objects for search params now expect URLSearchParams; add test for multiple values same key Implement URLSearchParams for search query: Most of the work is offloaded to URLSearchParams re: parsing and serializing, this change is predominatly updating the type of paramsObject Add polyfill for URLSearchParams: I.E. does not implement URLSearchParams
cailyncodes
force-pushed
the
url-search-params
branch
from
37cd939
to
5a4a84b
Compare
|
Unfortunately the extra dependency makes this unappealing I suppose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature in issue #88.
This pull request changes the object of
paramsObjectfrom a native JS object to aURLSearchParamsobject. The actual implementation is simple -- most of it is removing code becauseURLSeachParamshandles everything. The bulk of the changes are changes to the tests because this is a breaking change.