Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Use IronScrollManager and actionProperty #125

Merged
merged 8 commits into from
Oct 27, 2017
Merged

Conversation

valdrinkoshi
Copy link
Member

@valdrinkoshi valdrinkoshi commented Feb 27, 2017

Fixes #127,
Fixes #126,
Fixes #120,
Fixes #112,
Fixes #101

Use IronScrollManager from iron-overlay-behavior, deprecate IronDropdownScrollManager.

Now allowOutsideScroll sets scrollAction when toggled. Special handling for initial setup:

  • on ready, scrollAction is kept as is if defined, otherwise is setup according to allowOutsideScroll value
  • after ready, toggling allowOutsideScroll always updates scrollAction

TODO:

@e111077
Copy link
Contributor

e111077 commented May 23, 2017

Do you mind please linking to the PR that introduced this feature?

@valdrinkoshi
Copy link
Member Author

valdrinkoshi commented May 23, 2017

The scroll manager has always been part of iron-dropdown (see history of the file), I've been working on keeping the document overflow untouched and preventing the events in this PR #93

Update: the scroll manager was introduced in 1.0 (see this commit)

Copy link
Contributor

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@valdrinkoshi valdrinkoshi changed the title remove scroll manager Use IronScrollManager and actionProperty Oct 27, 2017
@valdrinkoshi
Copy link
Member Author

Will merge this as is, then change iron-overlay-behavior version in bower.json in a separate commit

@valdrinkoshi valdrinkoshi merged commit 3ae0030 into master Oct 27, 2017
@valdrinkoshi valdrinkoshi deleted the move-scroll-behavior branch October 27, 2017 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants