This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Use IronScrollManager and actionProperty #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you mind please linking to the PR that introduced this feature? |
The scroll manager has Update: the scroll manager was introduced in 1.0 (see this commit) |
4 tasks
cdata
approved these changes
Oct 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
valdrinkoshi
changed the title
remove scroll manager
Use IronScrollManager and actionProperty
Oct 27, 2017
Will merge this as is, then change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127,
Fixes #126,
Fixes #120,
Fixes #112,
Fixes #101
Use IronScrollManager from iron-overlay-behavior, deprecate IronDropdownScrollManager.
Now
allowOutsideScroll
setsscrollAction
when toggled. Special handling for initial setup:scrollAction
is kept as is if defined, otherwise is setup according toallowOutsideScroll
valueallowOutsideScroll
always updatesscrollAction
TODO: