This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
remove listener on detached #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the latest update of travis-ci os is breaking selenium.. https://www.traviscistatus.com/incidents/11hp8bhkrkn7 I've run the tests locally and they pass, but I'd wait to see travis tests be green before merging this. @azakus FYI |
|
@valdrinkoshi FF has been broken on Travis for a week, so I'm not sure you should wait for it :( |
|
@notwaldorf does this LGTY? Good to merge? |
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tests. This should have been done in PR #93. Tests were passing because of an earlier version of
iron-overlay-behaviorwhich was settingopened = falseon detached. This has been fixed in v1.8.6 PolymerElements/iron-overlay-behavior#183.Ah, dependencies..