buildable in closure save -> saveValue API change #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
suggested changes
Apr 13, 2017
| @@ -240,8 +242,8 @@ | |||
| port.addEventListener('message', function(event) { | |||
| this.handleClientMessage(event, port) | |||
| }.bind(this)); | |||
|
|
|||
| if (!(port in this[CLIENT_PORTS])) { | |||
| let isPortInClient = port.toString() in this[CLIENT_PORTS]; | |||
| @@ -307,7 +309,7 @@ | |||
| } | |||
| }; | |||
|
|
|||
| self.appIndexedDBMirrorWorker = new AppIndexedDBMirrorWorker(); | |||
| self.appIndexedDBMirrorWorker = new AppIndexedDBMirrorWorker('', ''); | |||
There was a problem hiding this comment.
Can we just annotate the constructor to suggest that there are defaults set internally?
| @@ -181,7 +181,7 @@ | |||
| * Worker spawned from `workerUrl`. | |||
| */ | |||
| client: { | |||
| type: Polymer.AppIndexedDBMirrorClient, | |||
| type: Object, | |||
There was a problem hiding this comment.
But why...? This is less accurate 😢
There was a problem hiding this comment.
It didn't like pointing to that. it kept saying that object was undefined
| @@ -253,7 +248,7 @@ | |||
| this.persistedData = this.data; | |||
| this.linkPaths('data', 'persistedData'); | |||
| } else { | |||
| this.unlinkPaths('data', 'persistedData'); | |||
| this.unlinkPaths('data'); | |||
| @@ -49,5 +49,5 @@ | |||
| } | |||
| }.bind(this)); | |||
|
|
|||
| self.importScripts([workerScript]); | |||
| self.importScripts(workerScript); | |||
There was a problem hiding this comment.
It's a small (JavaScript) miracle that this ever worked...
| @@ -95,10 +98,10 @@ | |||
| * A proxy method that forwards all calls to the backing `WebWorker` | |||
| * instance. | |||
| * | |||
| * @param {...} removeEventListenerArgs The arguments to call the same | |||
| * @param {Array} removeEventListenerArgs The arguments to call the same | |||
There was a problem hiding this comment.
I don't think this is right.
|
@cdata i got it! |
cdata
reviewed
Apr 13, 2017
| @@ -98,7 +101,7 @@ | |||
| * @param {...} removeEventListenerArgs The arguments to call the same | |||
| * method on the `WebWorker` with. | |||
| */ | |||
| removeEventListener: function() { | |||
| removeEventListener: function(removeEventListenerArgs) { | |||
There was a problem hiding this comment.
Remove removeEventListenerArgs?
|
@cdata double checked and it builds just fine |
|
LGTM 👍 |
cdata
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review DO NOT MERGE
This builds with closure and passes presubmit things