Do not compile NPMPackages which are used during testing #543
Conversation
| } | ||
|
|
||
| // scripts to be injected into the running test | ||
| export const ENVIRONMENT_SCRIPTS: NPMPackage[] = [ |
There was a problem hiding this comment.
What if we checked for a URL parameter like ?nocompile, and have WCT add that to the URLs it injects? Maybe that separates concerns better?
There was a problem hiding this comment.
Oooh I like that solution. Will take a stab at that 👍
There was a problem hiding this comment.
+1 to not adding more WCT-specific content directly to polyserve.
There was a problem hiding this comment.
Updated 👍 I will update the WCT stuff accordingly in the other PR to minimize noise.
TimvdLippe
force-pushed
the
do-not-compile-npm-packages
branch
from
f7516a0 to
1c18a07
Compare
| @@ -72,6 +74,9 @@ export function babelCompile( | |||
| if (isPolyfill.test(request.url)) { | |||
| return false; | |||
| } | |||
| if (shouldNotCompile.test(request.url)) { | |||
There was a problem hiding this comment.
Maybe use ('nocompile' in request.query) or similar so that nocompile doesn't have to be the first query parameter (e.g. foo&nocompile).
There was a problem hiding this comment.
|
@aomarks Right, I always forget that. Have to add that PR_TEMPLATE soonTM 😉 |
By moving this enumeration from WCT to Polyserve, we can now make sure we do not compile these dependencies (they do not need it anyway).
Fixes #538