Fix: WCT CLI arg standardizing

[stramel]

Supersedes Polymer/web-component-tester#698

Fixes #416 https://github.com/Polymer/polymer-cli/issues/919 https://github.com/Polymer/web-component-tester/issues/652

@usergenic

[merlinnot]

Breaking change btw ;)

[stramel]

Or is it a fix since it should have been this way in the first place? 🤔 😛

[usergenic]

Okay. I'll need to make the changelog item more explicit in case this does break somebody's use-case.

[usergenic]

hmm https://github.com/search?q=polymer+test+--configFile&type=Code

[usergenic]

I'm going to need to hold off on merging this one for now unless we can also extend the code to support the old form, since it is technically a breaking change and there are uses in-the-wild.

[stramel]

@usergenic I wonder if I could set alias: 'configFile'?

[usergenic]

@stramel that occurred to me too. haven't tested it but thats probably the way to go.

[stramel]

Yeah, I won't be able to test until I get home. But if it works I will update the PR and add a note

[merlinnot]

Maybe a deprecation warning on top of this? So we can actually drop it some day?

[stramel]

FYI: abbr or alias can only be a single character... I will look into a different way to resolve that issue.

[stramel]

@usergenic Perhaps this is just a happy coincidence but this isn't a breaking change, oddly enough. It is "breaking" in the sense that we are deprecating the configFile and simpleOutput option. However, nomnom the arg parser that is used in web-component-tester will match configFile and config-file after these changes. Where as previously it did not match config-file as configFile. See output below:

# Works with previous camelCase arg
$ ./packages/web-component-tester/bin/wct --configFile=polymer.test.json
args [ '--configFile=polymer.test.json' ]
options { configFile: 'polymer.test.json' }

# Works with added dash-case arg
$ ./packages/web-component-tester/bin/wct --config-file=polymer.test.json
args [ '--config-file=polymer.test.json' ]
options { configFile: 'polymer.test.json' }

Outputting the context.options after parsing appears to have the proper file set in both cases as well.

...
configFile: 'polymer.test.json',
...

Technically speaking any arg listed camelCase in the definition list will work camelCase even with full specified as dash-case.

NOTE: nomnom is deprecated and would probably be useful to move to command-line-args like the other packages on the next major breaking change release and coordinate that with the remove of camelCase arg support.

NOTE: cli should probably switch simpleOutput to be simple-output as well but that WILL be a breaking change since command-line-args does NOT treat args the same way as nomnom. (Heads up @krumware)

[usergenic]

@stramel whoa! how about that! okay, that's great work looking into that. After we merge this I'll add a test or something to ensure handling of both forms in the event someone decides to upgrade wct's arg parsing without knowing all this.

[usergenic]

I'll get this merged before tomorrow as soon as I can set aside a moment to craft that test.

[usergenic]

Had some other issues with CLI release branch on Friday; Will get this merged today (if possible!)

[stramel]

No worries! Thanks again @usergenic!

[usergenic]

@stramel this is getting released shortly after #515 gets approved. :)