Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wct] Use gts for linting and formatting #387

Closed
wants to merge 34 commits into from
Closed

[wct] Use gts for linting and formatting #387

wants to merge 34 commits into from

Conversation

koshilki
Copy link

  • Use gts instead of tslint+clang-format
  • Lint using NPM scripts instead of gulp
  • Fix formatting according to gts rules
  • Fix gts lint rules violations
  • Refactor clireporter status colorise method

Fixes #224

Co-authored-by: @merlinnot

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@koshilki
Copy link
Author

@merlinnot FYI

@koshilki koshilki changed the title Fix issue 224 Use gts for lining and formatting May 16, 2018
@koshilki koshilki changed the title Use gts for lining and formatting Use gts for lining and formatting May 16, 2018
@koshilki koshilki changed the title Use gts for lining and formatting [wct] Use gts for lining and formatting May 16, 2018
@merlinnot
Copy link
Contributor

I'm ok with my work being contributed to Google.

@koshilki
Copy link
Author

@googlebot CLA issue should be fixed by now

Copy link
Contributor

@merlinnot merlinnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we merge koshilki/tools#1

@koshilki koshilki changed the title [wct] Use gts for lining and formatting [wct] Use gts for linting and formatting May 30, 2018
@koshilki koshilki closed this May 30, 2018
@koshilki koshilki reopened this May 30, 2018
@koshilki koshilki closed this May 30, 2018
@koshilki koshilki reopened this May 30, 2018
@koshilki koshilki closed this May 31, 2018
@koshilki koshilki reopened this May 31, 2018
@koshilki koshilki closed this Jun 5, 2018
@koshilki koshilki reopened this Jun 5, 2018
justinfagnani pushed a commit that referenced this pull request Jul 10, 2018
* update how-to instructions with new flag passing info

* italic to bold
@stale
Copy link

stale bot commented Mar 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Mar 3, 2022

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wct] Moving from clang + tslint to gts
3 participants