[polymer-bundler] Fix issue where excludes that are redirected are ignored #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clearer what the file is actually testing.
|
/cc @freshp86 |
aomarks
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polymer Bundler CLI has a
--redirectoption that allows you to say things like--redirect something://like-this/|/some/folder/which is a thing some people need to do.The code that compares exclude URLs was not using URLs which were being resolved by the MultiUrlResolver that applied the URL rewriting from the provided redirection, which resulted in URLs not being excluded that should have been treated as excluded.
I also opportunistically renamed our polymer-bundler_test.ts file to cli_test.ts since that made the file's intention clearer.