Modules support now requires dynamic import and import.meta

[aomarks]

Modules support now requires dynamic import and import.meta.

Specifically, this means:

• Safari modules support is now from 11.1 instead of 10.1/10.3
• Chrome modules support is now from 64 instead of 61.
• Vivaldi supports modules (tested).

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

[rictic]

CLA status is good because it's just Al and me on this PR, and we're both googlers.

Looks like browser-capabilites tests are failing in a legit-looking way, saying that Chrome doesn't have module support? Maybe something's up where it's identifying the Chrome UA as Safari?

[rictic]

Oh, it's probably just because we pushed back the min Chrome version that we count as having modules support

[aomarks]

Looks like browser-capabilites tests are failing in a legit-looking way, saying that Chrome doesn't have module support? Maybe something's up where it's identifying the Chrome UA as Safari?

Yeah I just forgot to update the test last night, working on it.

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[keanulee]

Would be good to keep this test (updated expected of course) and add a new one for the latest Safari's

[aomarks]

Done.