Fix wrong AMD transform dependency/callback parameter ordering. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix AMD transform bug where if an HTML document had multiple type=module scripts, and any of them (apart from the first) had any kind of import, then that import was not accessible (because it was mapped to the wrong module callback function argument). Fixes #112
aomarks
force-pushed
the
amd-callback-params
branch
from
db44535 to
908542b
Compare
rictic
approved these changes
Apr 12, 2018
| @@ -5,7 +5,8 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](http://keepachangelog.com/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| <!-- ## Unreleased --> | |||
| ## Unreleased | |||
| * Fix AMD transform bug where if an HTML document had multiple type=module scripts, and any of them (apart from the first) had any kind of import, then that import was not accessible (because it was mapped to the wrong module callback function argument). | |||
There was a problem hiding this comment.
What about a policy where we update all affected packages' changelogs when there's important bugfixes or new features? So in this case we'd copy this change notice to CLI and Polyserve too.
That'll also help lerna publish infer when it should stamp a new release of a package.
This was referenced Jun 6, 2022
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AMD transform bug where if an HTML document had multiple type=module
scripts, and any of them (apart from the first) had any kind of import,
then that import was not accessible (because it was mapped to the wrong
module callback function argument).
Fixes #112