Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browserCapabilities] Opera always gets 'es5-bundled' #640

Closed
exunreal opened this issue Aug 14, 2018 · 3 comments
Closed

[browserCapabilities] Opera always gets 'es5-bundled' #640

exunreal opened this issue Aug 14, 2018 · 3 comments

Comments

@exunreal
Copy link
Contributor

I noticed that despite that Opera supports es2015 and push it always loads es5-bunled.
Example: https://shop.polymer-project.org

I found that the reason for that is in browserCapabilities.

In browser-capabilities.js there is a part with switch-case:

    'Chrome': chrome,
    'Chromium': chrome,
    'Chrome Headless': chrome,
    'OPR': {
        es2015: since(36),
        es2016: since(45),
        es2017: since(45),
        es2018: since(51),
        push: since(28),
        serviceworker: since(32),
        modules: since(48),
    },

Here OPR has to be replaced with Opera cause ua-parser-js never returns 'OPR' as broserName for any version of Opera.

P.S. I've tested on Opera 54.

@aomarks
Copy link
Member

aomarks commented Aug 14, 2018

Thanks for reporting, a PR would be welcome! :)

exunreal added a commit to exunreal/tools that referenced this issue Aug 16, 2018
Changes browserName of Opera in browserCapabilities
aomarks pushed a commit that referenced this issue Aug 20, 2018
Changes browserName of Opera in browserCapabilities
@aomarks
Copy link
Member

aomarks commented Aug 20, 2018

Released in 1.1.2

@TimvdLippe
Copy link
Contributor

@aomarks Would it be possible to issue a new CLI release to pick this fix up? Users are facing this issue with polymer serve: Polymer/polymer#5353 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants