Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm-amd-loader 404s test is flaky #507

Closed
aomarks opened this issue Jun 12, 2018 · 0 comments
Closed

esm-amd-loader 404s test is flaky #507

aomarks opened this issue Jun 12, 2018 · 0 comments
Assignees
@aomarks

Comments

@aomarks
Copy link
Member

aomarks commented Jun 12, 2018

The "calls error callback only once on multiple 404s" test appears to be flaky. I keep seeing different browsers fail this test on CI:

OS X 10.13 safari latest ✖ static/y/suite.html » dynamic require » calls error callback only once on multiple 404s
  expected 0 to equal 1
    <unknown> at                      AssertionError at /components/wct-browser-legacy/node_modules/chai/chai.js:5260:0
    <unknown> at                              assert at /components/wct-browser-legacy/node_modules/chai/chai.js:259:0
    <unknown> at                               equal at /components/wct-browser-legacy/node_modules/chai/chai.js:2006:0
    <unknown> at   http://localhost:8000/components/ at polymer/esm-amd-loader-test/lib/suite.js:225:0
chrome 67                Tests passed
Windows 8.1 IE 11        Beginning tests via http://localhost:8000/components/@polymer/esm-amd-loader-test/generated-index.html?cli_browser_id=0
firefox 60               Tests passed
OS X 10.13 safari latest Tests failed: 1 failed tests
Windows 10 microsoftedge latest Tests passed
Windows 8.1 IE 11        Tests passed
Test run ended in failure: 1 failed tests
@aomarks aomarks self-assigned this Jun 12, 2018
@aomarks aomarks changed the title esm-amd-loader test is flaky esm-amd-loader 404s test is flaky Jun 12, 2018
aomarks added a commit that referenced this issue Jun 12, 2018
@aomarks
Make esm-amd-loader dynamic require 404 test less flaky.
2598cd1 
Previously this test used a 1 second timeout to wait to see how many
times the error callback was called, which was flaky on CI. Now we
capture 404 errors and check callback calls after two 404s.

Fixes #507
aomarks added a commit that referenced this issue Jun 12, 2018
@aomarks
Make esm-amd-loader dynamic require 404 test not flaky.
e779ee0 
Previously this test used a 1 second timeout to wait to see how many
times the error callback was called, which was flaky on CI. Now we
capture 404 errors and check callback calls after two 404s.

Fixes #507
@aomarks aomarks mentioned this issue Jun 12, 2018
Merged
@Exnadella Exnadella mentioned this issue Nov 26, 2023
Open
@Exnadella Exnadella mentioned this issue Dec 19, 2023
Open
@Exnadella Exnadella mentioned this issue May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aomarks aomarks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aomarks