-
Notifications
You must be signed in to change notification settings - Fork 430
use single -s arg with comma separated list of sauce browsers #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the tests are green :D
🙏 |
@usergenic Tried to use comma separated list but it didn't work. Can you help us to figure out the right command to use? |
Now it's complaining these values don't match:
|
I was wrong about comma separated values. I haven't 100% confirmed the history but given the usage, the argument in cli's test command code should have been specified as 'multiple: true' but it wasn't-- I think a version update in recent package lock refresh must have brought in change to command-line-args library which now enforces single values unless specified as multiple. I tested the change locally and am going to try to get fixed in next release Polymer/tools#515 |
Tested fix by making
|
@usergenic Awesome! Thanks for looking into it. |
@frankiefu @notwaldorf wct 6.7.0 and polymer-cli 1.7.4 have both just been published which should solve this issue, i.e. multiple |
@usergenic Thanks! |
From @usergenic 's comment: #155 (review)
See if this fixes the test issue.