Loosen _attachDom return signature. #5666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rictic
requested changes
Jun 24, 2020
| _attachDom(dom) { | ||
| this.appendChild(dom); | ||
| return this; | ||
| } |
There was a problem hiding this comment.
Was this change necessary, or is it demonstrating usage?
With this change, the test element doesn't have a shadow root I think. Could we assert for that in this test?
There was a problem hiding this comment.
Not necessary. In the Contributor docs, it says every change has to be accompanied by some change in tests.
I'll try adding an assert.
|
Fixes #5665 |
|
Please also update the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue