-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespaces are being omitted #2775
Comments
This is a case that our The specific lines being transformed incorrectly are:
A simplified version is: Polymer.MyNamespace {
methodA() {...}
methodB() {
return this.methodA.bind(this);
}
} I'd rather fix this by hand after conversion, but if the goal is to keep 2.x source as the source-of-truth, then we'll have to extend the heuristic to recognize export function methodA() {...}
export function methodB() {
return methodA;
} |
cc @FredKSchott @kevinpschaaf and @graynorton I'm not sure how many more issues like this we have to get to 100% automation on our elements, but we're in the long tail for sure, IMO. |
spoken offline, we also suggested fixing this issue by making modulizer substitute |
Is this closable after #416 or is this different? |
When a namespace is defined, it seems as if the modulizer is ignoring it. e.g.
is converted to
see PolymerElements/iron-overlay-behavior/iron-scroll-manager.html _lockScrollInteractions
before
after
The text was updated successfully, but these errors were encountered: