Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Commit

Permalink
#345 has been resolved
Browse files Browse the repository at this point in the history
  • Loading branch information
Elliott Marquez committed May 4, 2018
1 parent 8a21f29 commit 197c797
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions docs/polymer-modulize-howto.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@

2. Run `NODE_OPTIONS="--max_old_space_size=8192" modulizer --clean --npm-version 3.0.0-pre.<N+1> --repo $(cat <modulizer dir>/docs/polymer-modulize-repos.txt | tr '\n' ' ') --delete-files bower.json '**/*.d.ts' types/ --import-style name`. This should take 2-3 minutes.

3. Open `modulizer_workspace/iron-overlay-behavior/iron-scroll-manager.js` and change the line `_boundScrollHandler || _scrollInteractionHandler.bind(Polymer.IronScrollManager);` to `_boundScrollHandler || _scrollInteractionHandler.bind(undefined);`, and make a new commit in that repo (until [#345](https://github.com/Polymer/polymer-modulizer/issues/345) is resolved.
3. Choose **"Install dependencies and run tests":** This should take 15-20 minutes when run with `--npm -l chrome` or `--npm --module-resolution=node -l chrome` flags (We specifically include "-l chrome" to only run tests in Chrome. Testing 90+ elements across multiple browsers is the goal, but it currently takes too long and generates too much noise to reliably parse.)

4. Choose **"Install dependencies and run tests":** This should take 15-20 minutes when run with `--npm -l chrome` or `--npm --module-resolution=node -l chrome` flags (We specifically include "-l chrome" to only run tests in Chrome. Testing 90+ elements across multiple browsers is the goal, but it currently takes too long and generates too much noise to reliably parse.)
4. Compare the test results with the [Element status](https://github.com/Polymer/polymer-modulizer/blob/master/docs/polymer-3-element-status.md) doc and spot check that 5-10 elements that were previously passing are still passing.

5. Compare the test results with the [Element status](https://github.com/Polymer/polymer-modulizer/blob/master/docs/polymer-3-element-status.md) doc and spot check that 5-10 elements that were previously passing are still passing.
5. Choose **"Push changes to GitHub":** Change the branch name to `__auto_generated_3.0_preview` when prompted (see [#258](https://github.com/Polymer/polymer-modulizer/issues/258)).

6. Choose **"Push changes to GitHub":** Change the branch name to `__auto_generated_3.0_preview` when prompted (see [#258](https://github.com/Polymer/polymer-modulizer/issues/258)).
6. Choose **"Publish changes to npm".**

7. Choose **"Publish changes to npm".**

8. Submit a PR to update `dependency-map.json` with the changes made in step 1.
7. Submit a PR to update `dependency-map.json` with the changes made in step 1.

0 comments on commit 197c797

Please sign in to comment.