fix(service-worker): update to fix important issue on FF and Chrome #201
Conversation
package.json
Outdated
| @@ -33,7 +33,7 @@ | |||
| "polymer-analyzer": "2.0.0-alpha.40", | |||
| "polymer-bundler": "2.0.0-pre.14", | |||
| "polymer-project-config": "^2.0.0", | |||
| "sw-precache": "^4.2.0", | |||
| "sw-precache": "^5.0.0", | |||
There was a problem hiding this comment.
5.1.1 is the latest version:
https://github.com/GoogleChrome/sw-precache/releases/tag/5.1.1
There was a problem hiding this comment.
^5.0.0 will get 5.1.1 and higher 5's, but it looks like there are some bug fixes in those later versions that we specifically want to include. +1 on changing this to ^5.1.1
|
sw-precache CHANGELOG here: https://github.com/GoogleChrome/sw-precache/releases It looks like I was wrong and there weren't any breaking interface changes, which is good. Can you add a note to our changelog that service worker caches will be repopulated when users update polymer-build? Adding a pointer to that release summary would be good as well. |
davinkevin
force-pushed
the
update-sw-precache
branch
2 times, most recently
from
62948cb to
89f7685
Compare
|
CHANGELOG.md updated and version align to your request, Thanks |
CHANGELOG.md
Outdated
| @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](http://keepachangelog.com/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Dependency updates. Upgraded to `[email protected]` minimum to prevent error about corrupted data on firefox 52 and Chrome 60 (witch match the spec) | |||
There was a problem hiding this comment.
As far as I know it doesn't work on Chrome >= 59.
Firefox >=50
CHANGELOG.md
Outdated
| @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](http://keepachangelog.com/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Dependency updates. Upgraded to `[email protected]` minimum to prevent error about corrupted data on firefox 52 and Chrome 60 (witch match the spec) | |||
CHANGELOG.md
Outdated
| @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](http://keepachangelog.com/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Dependency updates. Upgraded to `[email protected]` minimum to prevent error about corrupted data on firefox 52 and Chrome 60 (witch match the spec) | |||
There was a problem hiding this comment.
I believe that this should be Chrome 59. Probably want to capitalize Firefox. Did you mean 'which match the spec'?
There was a problem hiding this comment.
I should not do PR from my tablet in my bed around midnight... 😄
I do a new modification...
There was a problem hiding this comment.
@davinkevin Hey, no problem! Thanks for getting this PR kicked off!
davinkevin
force-pushed
the
update-sw-precache
branch
from
89f7685 to
03c5488
Compare
Link to gdg-x/hoverboard#253 and GDGToulouse/site-devfest-toulouse-2017#23 (and many more GDG website) Closes #199
davinkevin
force-pushed
the
update-sw-precache
branch
from
03c5488 to
816049f
Compare
There was a problem hiding this comment.
Thanks for contributing @davinkevin! I have a few small suggestions to improve the changelog but I'll merge this now and make those changes later.
Link to gdg-x/hoverboard#253 and GDGToulouse/site-devfest-toulouse-2017#23 (and many more GDG website)
Closes #199