Rewrite attribute handling to always avoid IE/Edge value parsing and rewriting #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfagnani
commented
Nov 19, 2018
|
Tested with pwa-starter-kit on Chrome/Edge/IE; didn't run into any obvious issues. |
kevinpschaaf
requested changes
Nov 20, 2018
|
@kevinpschaaf PTAL |
kevinpschaaf
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
LGTM after adding the suggested clarifications in comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #594
This changes attribute handling pretty significantly. First, it always rewrites attributes now. We could add back the conditional to only rewrite on Edge. Second, it removes the
isTextBindingcheck, and instead relies on thelastAttributeNameRegexcheck to tell us if an expression is in a text position. I was a bit worried about this regex matching for non-attribute cases, but not of the tests fail. I'll try to come up with some more cases to make sure.@frankiefu, @keanulee, and @azakus it'd be awesome to try this branch with more real-world templates like we have in PWASK and MWC, if you have a chance to do that.