Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: Illegal invocation error is thrown when using queryAssignedNodes with text nodes #1088

Closed
5 tasks
dmondev opened this issue Oct 11, 2020 · 1 comment · Fixed by #1092
Closed
5 tasks

TypeError: Illegal invocation error is thrown when using queryAssignedNodes with text nodes #1088

dmondev opened this issue Oct 11, 2020 · 1 comment · Fixed by #1092
Assignees
@sorvell
Labels
Focus Area: Core Libraries Type: Bug Why: Reduce adoption friction

Comments

@dmondev
Copy link

dmondev commented Oct 11, 2020

Description

queryAssignedNodes throws A "TypeError: Illegal invocation" when slotted content contains text nodes.

Live Demo

https://webcomponents.dev/edit/FXrFMojSYzYa8eJNaJzh

Steps to Reproduce

  1. Create my-element with child nodes containing text.

Expected Results

No error is throw

Actual Results

TypeError: Illegal invocation is thrown

Browsers Affected (Haven't tested in other browsers)

  • [x ] Chrome
  • Firefox
  • Edge
  • Safari 11
  • Safari 10
  • IE 11

Versions

Uses the default/current version in https://webcomponents.dev
@sorvell
Copy link
Member

sorvell commented Oct 15, 2020

Acknowledged. This is due to a typo in the code and there's obviously not a good test for this. We'll work on getting it fixed. Thanks.

@sorvell sorvell self-assigned this Oct 15, 2020
sorvell pushed a commit to lit/lit that referenced this issue Oct 16, 2020
Fixes queryAssignedNodes when querying for nodes on browsers that do …
377c844 
…not support Element.matches

Fixes lit/lit-element#1088
@sorvell sorvell mentioned this issue Oct 16, 2020
Merged
sorvell pushed a commit that referenced this issue Oct 16, 2020
Fixes queryAssignedNodes when querying for nodes on browsers that do …
08af318 
…have Element.matches

Fixes #1088.
@sorvell sorvell mentioned this issue Oct 16, 2020
Merged
sorvell pushed a commit to lit/lit that referenced this issue Oct 22, 2020
[lit-next] Fixes queryAssignedNodes when querying for nodes on browse…
d4dddcc 
…rs that do … (#1373)

Fixes queryAssignedNodes when querying for nodes on browsers that do not support Element.matches
Fixes lit/lit-element#1088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
Focus Area: Core Libraries Type: Bug Why: Reduce adoption friction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes queryAssignedNodes when querying for nodes on browsers that do … lit/lit-element
2 participants
@sorvell @dmondev