Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: reset question if too early price is received from the DVM #56

Merged
merged 10 commits into from
Oct 25, 2022
Merged

Fix: reset question if too early price is received from the DVM #56

merged 10 commits into from
Oct 25, 2022

Conversation

JonathanAmenechi
Copy link
Contributor

@JonathanAmenechi JonathanAmenechi commented Oct 21, 2022 •
edited
Loading

Overview

  • resolve resets the Adapter question if the DVM returns the ignore price(type(int256).min)

Description

Testing instructions

Types of changes

  • Refactor/enhancement
  • Bug fix/behavior correction
  • New feature
  • Breaking change
  • Other, additional

Notes

Status

  • Prefix PR title with WIP if necessary (changes not yet made).
  • Add tests to cover changes as needed.
  • Update documentation/changelog as needed.
  • Verify all tests run correctly in CI and pass.
  • Ready for review/merge.

@JonathanAmenechi JonathanAmenechi changed the title WIP: Fix: reset question if too early price is received WIP: Fix: reset question if too early price is received from the DVM Oct 21, 2022
@JonathanAmenechi JonathanAmenechi changed the title WIP: Fix: reset question if too early price is received from the DVM Fix: reset question if too early price is received from the DVM Oct 21, 2022
mshrieve
mshrieve requested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@mshrieve mshrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, left a few comments!

src/UmaCtfAdapter.sol Outdated Show resolved Hide resolved
src/UmaCtfAdapter.sol Outdated Show resolved Hide resolved
src/UmaCtfAdapter.sol Show resolved Hide resolved
mshrieve
mshrieve approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@mshrieve mshrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonathanAmenechi JonathanAmenechi merged commit 3ad05fe into main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshrieve mshrieve mshrieve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanAmenechi @mshrieve