models: fix EventRecord default saved_at timestamp type #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used the fancy https://docs.djangoproject.com/fr/2.2/ref/contrib/postgres/functions/#transactionnow it returns the START of the database transaction. This is actually not a desirable behaviour for a `saved_at` field. We want the time at which it was recorded, not when the enclosing transaction begun, which may be an hour ago for example with a very long job. Note: I think TransactionNow would be useful if we had a timestamp to assess the time validity of an object. In that case, knowing when the transaction that wrote it started would indeed be nice.
bors-ltd
reviewed
Oct 24, 2019
| name='saved_at', | ||
| field=models.DateTimeField(auto_now=True, db_index=True), | ||
| ), | ||
| ] |
There was a problem hiding this comment.
AlterField migrations are post-deploy.
| @@ -5,6 +5,7 @@ Changelog | |||
| ------------------- | |||
|
|
|||
| - Aggregator field on the Application admin was wrongly required. | |||
| - Fix default `saved_at` for event records | |||
There was a problem hiding this comment.
You're not in par with the latest master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used the fancy https://docs.djangoproject.com/fr/2.2/ref/contrib/postgres/functions/#transactionnow
it returns the START of the database transaction.
This is actually not a desirable behaviour for a
saved_atfield. We want the timeat which it was recorded, not when the enclosing transaction begun, which may be
an hour ago for example with a very long job.
Note: I think TransactionNow would be useful if we had a timestamp to
assess the time validity of an object. In that case, knowing when the transaction
that wrote it started would indeed be nice.