Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace use of deprecated pkg_resources by importlib #69

Merged
merged 1 commit into from
May 14, 2024

Conversation

dbaty
Copy link
Member

@dbaty dbaty commented Sep 20, 2023

pkg_resources is deprecated (https://setuptools.pypa.io/en/latest/pkg_resources.html).

Closes #65.

@dbaty dbaty force-pushed the dbaty/remove_pkg_resources branch from e92b687 to a6f2387 Compare September 20, 2023 17:06
@sshishov
Copy link

@dbaty when we can expect this PR to be landed on the codebase?

We are receiving this warning and it would be nice to fix it... Half a year passed since the PR opened (1 file, 2 lines) and still not merged/released.

Thank you for continuous support!

Best regards,
Sergei

@dbaty
Copy link
Member Author

dbaty commented May 14, 2024

I plan to release a new version with this fix this week. Sorry for the delay.

Copy link

@RemiCardona RemiCardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks to the both of you (cc @nicolasmota)

@dbaty dbaty merged commit a6f2387 into master May 14, 2024
23 checks passed
@dbaty dbaty deleted the dbaty/remove_pkg_resources branch May 14, 2024 15:04
@dbaty
Copy link
Member Author

dbaty commented May 14, 2024

@sshishov : I have released version 3.0 today that contains this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg_resources is deprecated
3 participants