Bugfix: Fail to dismiss the Message Dialog merely in MacOS #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the command-line context fails to dismissing itself posterior to click the button "OK". 2. Solution: If the parent-window handle is absent during the initialization of the MessageDialog instance, the ABI `CFUserNotificationDisplayAlert` will be invoked to pop up a message dialog, instead of instantiate a NSAlert instance. 3. Ramification: Only message dialog for MacOS 4. Unit Test: cover both sync and async message dialogs and run the unit test by `cargo run --example msg`
PolyMeilex
reviewed
Nov 17, 2024
1. Remove the conditional dependency on the `futures` crate. 2. Relinquish the heavy thread-pool instrument. 3. Spawn a background thread by means of the std lib.
…into `ModalFuture::new(..)`
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFUserNotificationDisplayAlertwill be invoked to pop up a message dialog, instead of instantiating a NSAlert object.cargo run --example msg