Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Zenity backend optional #160

Closed
wants to merge 1 commit into from

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Nov 28, 2023

Saves some Rust dependencies for users who are willing to require gtk3 (the default) or who don't want message dialogs at all.

Saves some Rust dependencies for users who are willing to require gtk3
(the default) or who don't want message dialogs at all.
@Ralith
Copy link
Contributor Author

Ralith commented Nov 28, 2023

Alternatively, the zenity backend could be rewritten to spawn a background thread rather than relying on async-io, making it much lighter weight and more portable. Adaptation to futures could use something like oneshot or a trivial hand-rolled channel.

@PolyMeilex
Copy link
Owner

Alternatively, the zenity backend could be rewritten to spawn a background thread

Sounds like a better idea, I will do that instead in spare time.

@Ralith
Copy link
Contributor Author

Ralith commented Dec 9, 2023

Thanks!

@Ralith Ralith closed this Dec 9, 2023
@Ralith Ralith deleted the optional-zenity branch December 9, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants