Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up of PR153 #159

Merged
merged 12 commits into from
Oct 31, 2023
Merged

Follow-up of PR153 #159

merged 12 commits into from
Oct 31, 2023

Conversation

sameeul
Copy link
Member

@sameeul sameeul commented Oct 27, 2023

Follow-up of #153
The goal is to encapsulate ApacheArrowWriter within ArrowOutputStream and remove some exception throwing.
Along with that there are some minor clean-up.

@sweep-ai
Copy link

sweep-ai bot commented Oct 27, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sameeul sameeul closed this Oct 27, 2023
@sameeul sameeul reopened this Oct 27, 2023
@sameeul sameeul merged commit 007917d into PolusAI:main Oct 31, 2023
18 checks passed
@sameeul sameeul deleted the update_153_2 branch October 31, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants