Thursday night patch #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Polkadot-Blockchain-Academy/pba-content#600 (comment) looks like diff file & patch to downstream is best - tried mucking with merging from different remotes to only get pain. e should put this branch & pr on https://github.com/Polkadot-Blockchain-Academy/pba-ucb-a2-contracts so students can see it & attach the diff file to the PR comments with instructions to apply it |
nuke-web3
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few small errors that students pointed out during an impromptu late night help session.
check_merkle_proofverify_*functions returnResult<bool>to handle payment problemsheader_is_*functions take&self