Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning & conventions for Econ module 2 - Post UCB #853

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Conversation

nuke-web3
Copy link

@nuke-web3 nuke-web3 commented Aug 12, 2023

Part of #710

TODO

@nuke-web3 nuke-web3 requested review from coax1d and jonasW3F August 12, 2023 13:24
@nuke-web3 nuke-web3 changed the title Cleaning & conventions for Substrate module 5 - Post UCB Cleaning & conventions for Econ module 2 - Post UCB Aug 12, 2023
@nuke-web3 nuke-web3 added the DO NOT MERGE Don't merge this one while this tag is assigned to it!! label Aug 13, 2023
@nuke-web3
Copy link
Author

FYI waiting on #855 to be resolved before this is merged.

@nuke-web3 nuke-web3 removed the DO NOT MERGE Don't merge this one while this tag is assigned to it!! label Aug 21, 2023
@nuke-web3
Copy link
Author

@jonasW3F @AlfonsoCev I am going to merge this as is, so it's easy to view on https://do-not-share-pba-internal.on.fleek.co/

In the source, you only need to look at files in syllabus/2-Economics - all else is external, no assets/... separation anymore.

Note that this PR's OP still has TODO items I hope you can do ASAP to get into the new book - here is the WIP repo for that: https://github.com/Polkadot-Blockchain-Academy/testing-only

I am happy to migrate changes from here to there. We need to get this done yesterday so please to rush. 🙏

@nuke-web3 nuke-web3 merged commit 1e07ffb into main Aug 21, 2023
@nuke-web3 nuke-web3 deleted the n/econ-post-ucb branch August 21, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant