Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning & conventions for Substrate module 5 - Post UCB #852

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

nuke-web3
Copy link

@nuke-web3 nuke-web3 commented Aug 12, 2023

WIP

Part of #761

TODO

@nuke-web3 nuke-web3 requested a review from kianenigma August 12, 2023 13:21
Copy link
Member

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this sooner to avoid conflicts once I start to make content changes.

@kianenigma
Copy link
Member

Migrate code into dedicated repo(s) for Substrate module #718 with help from @kianenigma 🙏

Suggest this to be done separately as it is more involved.

@kianenigma
Copy link
Member

merging this as-is to avoid conflict with any further work.

@kianenigma kianenigma merged commit 0786dc6 into main Aug 13, 2023
@kianenigma kianenigma deleted the n/substrate-post-ucb branch August 13, 2023 20:08
@kianenigma
Copy link
Member

kianenigma commented Aug 13, 2023

This is half finished, so I will revert it again, sorry.

@nukemandan I will leave this asset refactoring up to you.

TBH I think the old structure is fine. What I recommend doing instead is #855

kianenigma added a commit that referenced this pull request Aug 13, 2023
kianenigma added a commit that referenced this pull request Aug 13, 2023
Revert "Cleaning & conventions for Substrate module 5 - Post UCB (#852)"

This reverts commit 0786dc6.
@nuke-web3 nuke-web3 mentioned this pull request Aug 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants