Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/plmc 239 end 2 end test #68

Merged
merged 26 commits into from
Aug 30, 2023
Merged

Feature/plmc 239 end 2 end test #68

merged 26 commits into from
Aug 30, 2023

Conversation

lrazovic
Copy link
Member

@lrazovic lrazovic commented Aug 14, 2023 •
edited
Loading

  1. Add tests based on the calculation example provided by Simon (available here).
  2. Reworked and split the calculate_fees function.

To address in a future PR:

  1. Refactor it to take values from a .csv file.
  2. Fix the Issue below. (Maybe we can test it again after the merge of Refactor test framework to be used in XCM-emulator and benchmarks #77)

    polimec-node/pallets/funding/src/tests.rs

    Line 8196 in 377a8b8

    // TODO: XI is a partipant in the Community Round AND an Evaluator. At the moment, this returns `InsufficientBalance` because it seems we don't mint to him enough USDT.

@linear
Copy link

linear bot commented Aug 14, 2023

PLMC-239 "end 2 end" test

Simon provided a full Project flow, from the beginning to the CT minting. src: https://docs.google.com/spreadsheets/d/1yctYOJ3A_xZQRCY4Ra4-fU7AbBmeseWk/edit?usp=sharing&ouid=104993149112379705499&rtpof=true&sd=true

We should use it as a "test reference" to test the full flow of the pallet-funding.

@JuaniRios JuaniRios self-requested a review August 18, 2023 13:09
@lrazovic
feat: restore assert_matches macro
cb5a2d6
@lrazovic
test: add the remainder round from excel
2562ff4
@lrazovic
test: add more dbg outputs
668b751
@lrazovic
refactor: split the fees calculation login in several fn
a26bb1f
@lrazovic
test: cleanup debug artefacts
7ef379d
@lrazovic
feat: calculate the CT amount in CT directly
54ba906
@lrazovic
fix: use the Y from the KH
b61aa6a
@lrazovic
feat: just return the total_fee_weight
a4f0d68
@lrazovic
doc: specify the denomination of the pot
a88966e
@lrazovic
test: restore the assert_matches macro
ceacd63
@lrazovic
git merge --squash -Xours origin/main
ca45364 
Squashed commit of the following:

commit a71eff7
Author: Juan Ignacio Rios <[email protected]>
Date:   Mon Aug 14 16:20:48 2023 +0200

    feat(243): Remove T::StorageItemId and replace it with hardcoded u32

commit 368abd9
Author: Juan Ignacio Rios <[email protected]>
Date:   Mon Aug 14 16:20:48 2023 +0200

    feat(249): Remove Option from Multipliers

    feat(249): Option no longer required for multipliers

    fix(243): rebase error

    chore(243): add import

    feat(245): manual and automatic release of PLMC and funding assets implemented and tested

    feat(247): manual and automatic release of PLMC and funding assets implemented and tested

    feat(247): manual release implemented and tested

    feat(247): automatic release implemented and tested

    feat(247): automatic release implemented and tested

    feat(248): manual release implemented and tested

    feat(248): automatic release implemented and tested

    wip

    feat(242): small optimization

    chore(242): fmt

    feat(242): change week to day conversion on config type

    feat(242): small changes from Leonardo's feedback

    Update pallets/funding/src/types.rs

    Co-authored-by: Leonardo Razovic <[email protected]>

    feat(244): linear increase of duration based on vesting

    wip

commit e576cdc
Author: Juan Ignacio Rios <[email protected]>
Date:   Fri Aug 25 10:39:03 2023 +0100

    fix(243): rebase error (#72)

    chore(243): add import

    feat(245): manual and automatic release of PLMC and funding assets implemented and tested

    feat(247): manual and automatic release of PLMC and funding assets implemented and tested

    feat(247): manual release implemented and tested

    feat(247): automatic release implemented and tested

    feat(247): automatic release implemented and tested

    feat(248): manual release implemented and tested

    feat(248): automatic release implemented and tested

commit bdc9075
Author: Leonardo Razovic <[email protected]>
Date:   Thu Aug 24 16:47:25 2023 +0200

    Update check.yml (#78)

    * Update check.yml

    * Update check.yml

commit 6894904
Author: Juan Ignacio Rios <[email protected]>
Date:   Wed Aug 23 14:17:19 2023 +0100

    Feature/plmc 242 implement correct duration of vesting (#70)

    * wip

    * feat(244): linear increase of duration based on vesting

    * Update pallets/funding/src/types.rs

    Co-authored-by: Leonardo Razovic <[email protected]>

    * feat(242): small changes from Leonardo's feedback

    * feat(242): change week to day conversion on config type

    * chore(242): fmt

    * feat(242): small optimization

    ---------

    Co-authored-by: Leonardo Razovic <[email protected]>

commit 8057e2e
Author: Leonardo Razovic <[email protected]>
Date:   Wed Aug 23 11:38:43 2023 +0200

    Update check.yml (#76)

commit b4579cc
Author: Leonardo Razovic <[email protected]>
Date:   Wed Aug 23 10:01:42 2023 +0200

    feat: update the CI to use paritytech/ci-linux:production (#73)

    * feat: update the CI to use paritytech/ci-linux:production

    * ci: execute fmt as a fail fast job

    * fmt: format to test the CI

    * feat: remove the check job
@lrazovic lrazovic removed the request for review from JuaniRios August 28, 2023 11:30
@lrazovic lrazovic changed the base branch from main to chore/integration-test-fix August 28, 2023 11:43
@lrazovic lrazovic changed the base branch from chore/integration-test-fix to main August 28, 2023 11:43
@lrazovic
feat: for testing purposes let's assume 1 USDT = 1USD
2c31b44 
wip

wip: align TestBid creation

wip: switch to stable compiler

test: check the remainder

Update rust-toolchain.toml

Co-authored-by: Leonardo Razovic <[email protected]>

chore(244): move dep to workspace

wip: check the ct amount

feat: restore assert_matches macro

test: add the remainder round from excel

test: add more dbg outputs

refactor: split the fees calculation login in several fn

test: cleanup debug artefacts

feat: calculate the CT amount in CT directly

fix: use the Y from the KH

feat: just return the total_fee_weight

doc: specify the denomination of the pot

test: restore the assert_matches macro

git merge --squash -Xours origin/main

Squashed commit of the following:

commit a71eff7
Author: Juan Ignacio Rios <[email protected]>
Date:   Mon Aug 14 16:20:48 2023 +0200

    feat(243): Remove T::StorageItemId and replace it with hardcoded u32

commit 368abd9
Author: Juan Ignacio Rios <[email protected]>
Date:   Mon Aug 14 16:20:48 2023 +0200

    feat(249): Remove Option from Multipliers

    feat(249): Option no longer required for multipliers

    fix(243): rebase error

    chore(243): add import

    feat(245): manual and automatic release of PLMC and funding assets implemented and tested

    feat(247): manual and automatic release of PLMC and funding assets implemented and tested

    feat(247): manual release implemented and tested

    feat(247): automatic release implemented and tested

    feat(247): automatic release implemented and tested

    feat(248): manual release implemented and tested

    feat(248): automatic release implemented and tested

    wip

    feat(242): small optimization

    chore(242): fmt

    feat(242): change week to day conversion on config type

    feat(242): small changes from Leonardo's feedback

    Update pallets/funding/src/types.rs

    Co-authored-by: Leonardo Razovic <[email protected]>

    feat(244): linear increase of duration based on vesting

    wip

commit e576cdc
Author: Juan Ignacio Rios <[email protected]>
Date:   Fri Aug 25 10:39:03 2023 +0100

    fix(243): rebase error (#72)

    chore(243): add import

    feat(245): manual and automatic release of PLMC and funding assets implemented and tested

    feat(247): manual and automatic release of PLMC and funding assets implemented and tested

    feat(247): manual release implemented and tested

    feat(247): automatic release implemented and tested

    feat(247): automatic release implemented and tested

    feat(248): manual release implemented and tested

    feat(248): automatic release implemented and tested

commit bdc9075
Author: Leonardo Razovic <[email protected]>
Date:   Thu Aug 24 16:47:25 2023 +0200

    Update check.yml (#78)

    * Update check.yml

    * Update check.yml

commit 6894904
Author: Juan Ignacio Rios <[email protected]>
Date:   Wed Aug 23 14:17:19 2023 +0100

    Feature/plmc 242 implement correct duration of vesting (#70)

    * wip

    * feat(244): linear increase of duration based on vesting

    * Update pallets/funding/src/types.rs

    Co-authored-by: Leonardo Razovic <[email protected]>

    * feat(242): small changes from Leonardo's feedback

    * feat(242): change week to day conversion on config type

    * chore(242): fmt

    * feat(242): small optimization

    ---------

    Co-authored-by: Leonardo Razovic <[email protected]>

commit 8057e2e
Author: Leonardo Razovic <[email protected]>
Date:   Wed Aug 23 11:38:43 2023 +0200

    Update check.yml (#76)

commit b4579cc
Author: Leonardo Razovic <[email protected]>
Date:   Wed Aug 23 10:01:42 2023 +0200

    feat: update the CI to use paritytech/ci-linux:production (#73)

    * feat: update the CI to use paritytech/ci-linux:production

    * ci: execute fmt as a fail fast job

    * fmt: format to test the CI

    * feat: remove the check job
@lrazovic
Merge branch 'feature/plmc-239-end-2-end-test' of github.com:Polimec/…
c405e0f 
…polimec-node into feature/plmc-239-end-2-end-test
@lrazovic lrazovic marked this pull request as ready for review August 28, 2023 14:21
@lrazovic @JuaniRios
feat(239): add remark to a skipped user
7768cd5 
feat(239): add comments to `generate_evaluator_rewards_info` function

fmt
@JuaniRios JuaniRios force-pushed the feature/plmc-239-end-2-end-test branch from 377a8b8 to 7768cd5 Compare August 30, 2023 14:17
@JuaniRios JuaniRios merged commit 3b8dd40 into main Aug 30, 2023
2 checks passed
@JuaniRios
Copy link
Contributor

LGTM

@JuaniRios JuaniRios deleted the feature/plmc-239-end-2-end-test branch August 30, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuaniRios JuaniRios Awaiting requested review from JuaniRios

Assignees

@lrazovic lrazovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lrazovic @JuaniRios