Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: manual acceptance and rejection of funding by project #51

Merged
merged 8 commits into from
Jul 26, 2023
Merged

Feat: manual acceptance and rejection of funding by project #51

merged 8 commits into from
Jul 26, 2023

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 21, 2023 •
edited
Loading

Objective

  • Make it so a project needs to manually accept or deny the funding if it falls within a certain threshold of the target funding.
  • Manual acceptance should be automatically considered as accepted after a certain period.
  • After a project is considered accepted, the actual settlement of CT creation and Finalizer instantiation should happen after another time period

@linear
Copy link

linear bot commented Jul 21, 2023

PLMC-222 Manual acceptance or rejection of funding

@JuaniRios JuaniRios force-pushed the feature/plmc-222-manual-acceptance-or-rejection-of-funding branch from 0cf9b79 to 339e053 Compare July 24, 2023 13:02
@JuaniRios
feat(222): starting to write test for <= 33 funding. Need first a new…
1ef4e37 
… PR for FinishedFunding being also a failed project

feat(222): new state `AwaitingProjectDecision`

wip(222)

feat(220): remove outcome generation abstraction and unused evaluator reward getter function. Abstract last step in success or failed project logic from do_end_funding to use in manual acceptance/rejection
@JuaniRios
chore(222): fmt
72a53af
@JuaniRios
chore(222): fmt
8a9dea2
@JuaniRios JuaniRios force-pushed the feature/plmc-222-manual-acceptance-or-rejection-of-funding branch from 339e053 to 8a9dea2 Compare July 24, 2023 13:12
@JuaniRios JuaniRios requested a review from lrazovic July 25, 2023 14:36
@JuaniRios JuaniRios self-assigned this Jul 25, 2023
@JuaniRios JuaniRios marked this pull request as ready for review July 25, 2023 14:36
@lrazovic lrazovic merged commit 95b9d3a into main Jul 26, 2023
1 of 2 checks passed
@lrazovic lrazovic deleted the feature/plmc-222-manual-acceptance-or-rejection-of-funding branch October 11, 2023 07:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

test: Failed ❌
https://github.com/Polimec/polimec-node/actions/runs/8145414302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic