Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📡 Add XCM Runtime APIs #414

Merged
merged 1 commit into from
Oct 14, 2024
Merged

📡 Add XCM Runtime APIs #414

merged 1 commit into from
Oct 14, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Oct 10, 2024

What?

Add XCM payment apis to the runtime

How?

Most are just a simple copy paste to the pallet function, but a couple of them need some specific config due to asset payment.

Testing?

integration tests in runtime_apis.rs

@lrazovic lrazovic force-pushed the 10-10-add_missing_extrinsics_to_call_filter branch from 324d42d to 2af9c37 Compare October 10, 2024 12:20
@JuaniRios JuaniRios force-pushed the 10-10-add_missing_extrinsics_to_call_filter branch from 2af9c37 to 324d42d Compare October 10, 2024 12:23
@JuaniRios JuaniRios force-pushed the 10-10-add_xcm_runtime_apis branch 2 times, most recently from 85dbaf0 to 0ddbb47 Compare October 10, 2024 13:43
@JuaniRios JuaniRios force-pushed the 10-10-add_missing_extrinsics_to_call_filter branch from 324d42d to ee4b0c4 Compare October 10, 2024 13:45
@JuaniRios JuaniRios force-pushed the 10-10-add_missing_extrinsics_to_call_filter branch from ee4b0c4 to fe4f161 Compare October 10, 2024 13:47
@JuaniRios JuaniRios force-pushed the 10-10-add_xcm_runtime_apis branch 3 times, most recently from 41dae2e to 35802a3 Compare October 10, 2024 13:56
@JuaniRios JuaniRios changed the base branch from 10-10-add_missing_extrinsics_to_call_filter to 10-10-feat_remove_randomness_pallet_plmc-602_ October 10, 2024 13:56
@JuaniRios JuaniRios force-pushed the 10-10-feat_remove_randomness_pallet_plmc-602_ branch from e6a273f to 2af3359 Compare October 10, 2024 14:07
@JuaniRios JuaniRios changed the title add xcm runtime apis 📡 Add XCM Runtime APIs Oct 10, 2024
@JuaniRios JuaniRios changed the base branch from 10-10-feat_remove_randomness_pallet_plmc-602_ to graphite-base/414 October 10, 2024 14:38
@JuaniRios JuaniRios changed the base branch from graphite-base/414 to main October 10, 2024 14:41
@JuaniRios JuaniRios force-pushed the 10-10-add_xcm_runtime_apis branch 2 times, most recently from ad8de4c to db41617 Compare October 11, 2024 10:30
@JuaniRios JuaniRios self-assigned this Oct 11, 2024
@JuaniRios JuaniRios marked this pull request as ready for review October 11, 2024 10:35
@JuaniRios JuaniRios changed the base branch from main to 10-11-feat_add_fungibles_runtime_api_-_plmc-606 October 11, 2024 10:49
@lrazovic lrazovic force-pushed the 10-11-feat_add_fungibles_runtime_api_-_plmc-606 branch from 1faa20c to 8b39a88 Compare October 11, 2024 12:52
integration-tests/src/tests/runtime_apis.rs Show resolved Hide resolved
integration-tests/src/tests/runtime_apis.rs Show resolved Hide resolved
integration-tests/src/tests/runtime_apis.rs Show resolved Hide resolved
polimec-common/common/src/lib.rs Show resolved Hide resolved
runtimes/polimec/src/lib.rs Show resolved Hide resolved
scripts/zombienet/polimec-paseo-local.toml Show resolved Hide resolved
Base automatically changed from 10-11-feat_add_fungibles_runtime_api_-_plmc-606 to main October 11, 2024 13:04
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the comments are addressed in PR #416.

Copy link
Member

lrazovic commented Oct 14, 2024

Merge activity

  • Oct 14, 9:51 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 14, 9:52 AM EDT: A user merged this pull request with Graphite.
  • Oct 14, 9:52 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (Your push would publish a private email address. You can make your email public or disable this protection on GitHub).

@lrazovic lrazovic merged commit 575002d into main Oct 14, 2024
1 check passed
@lrazovic lrazovic deleted the 10-10-add_xcm_runtime_apis branch October 14, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants