-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/plmc 290 xcm instruction that reveals polimecs balance and pallet #114
Feature/plmc 290 xcm instruction that reveals polimecs balance and pallet #114
Conversation
automatic hrmp connection working Genesis instantiator usage and first draft of HRMP connection formatting feature propagation cleanup new node functioning. genesis not yet sure if working new node functioning. genesis not yet sure if working somehow compiling and test passing save save save feat(287): para_id setting extrinsic implemented and tested save same log crate across workspace same log crate across workspace save save save feat(287): changed tight couple of pallet_xcm by extracting sender trait feat(287): first commit feat(285): POC Hrmp automatic acceptance
# Conflicts: # Cargo.lock # Cargo.toml # integration-tests/src/tests/mod.rs # pallets/funding/Cargo.toml # pallets/funding/src/functions.rs # pallets/funding/src/instantiator.rs # pallets/funding/src/lib.rs # pallets/funding/src/mock.rs # pallets/funding/src/types.rs # pallets/xcm-executor/src/config.rs # pallets/xcm-executor/src/lib.rs # runtimes/standalone/src/lib.rs # runtimes/testnet/src/xcm_config.rs
…s-polimecs-balance-and-pallet # Conflicts: # Cargo.toml
/bot fmt |
…s-polimecs-balance-and-pallet # Conflicts: # Cargo.toml # integration-tests/src/tests/mod.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few nitpicks that I would love to address offline, but overall a huge new set of feature towards the MVP!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with the changes requested by Leonardo. I do not really like the tight coupling on pallet-xcm, but I do not really see another way without implementing the same logic as pallet-xcm with adding a callback on query response.
Objective
Tech
QueryPallet
andReportHolding
on the project chain after HRMP has been establishedPalletInfo
because the fields are private and we cannot retrieve values and compare/store them. More importantly this means we have to expect the pallet to have a certain index which is dumb, but will be addressed in Polkadot-SDK PR #2231, after which we can store the index and use it for the migration.Main Changes
start_migration_readiness_check
: called automatically when HRMP is established, and by the issuer when the check failed, so we can retry.migration_check_response
: called by the chain after processing our QueryPallet and ReportHolding instructions.cargo test
, but need to callcargo test --features std,testing-node
. For more info why, check this link