-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💥 Switch to MultiLocation in the SignedExtension #406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
Merged
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 4, 2024 09:50
20d1727
to
7bcdb3c
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 4, 2024 10:32
d099958
to
8b19fd8
Compare
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 4, 2024 10:32
7bcdb3c
to
126d1db
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 4, 2024 12:17
8b19fd8
to
a9bd91b
Compare
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 4, 2024 12:18
126d1db
to
647e303
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 7, 2024 13:02
a9bd91b
to
474234a
Compare
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 7, 2024 13:02
647e303
to
ee5553b
Compare
lrazovic
force-pushed
the
09-25-new_e2e_tests
branch
from
October 8, 2024 13:27
474234a
to
b52b088
Compare
lrazovic
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
2 times, most recently
from
October 8, 2024 13:29
8b80f9b
to
17de30f
Compare
lrazovic
changed the title
usdt-fee-pjs-compatibility
💥 Switch to MultiLocation in the SignedExtension
Oct 8, 2024
lrazovic
previously approved these changes
Oct 8, 2024
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (10/08/24)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
lrazovic
dismissed
their stale review
October 9, 2024 08:50
After a cargo clean
(even if I tested it using srtool
), it doesn't compile. On it.
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 9, 2024 09:59
b52b088
to
029390d
Compare
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 9, 2024 10:00
17de30f
to
339eefb
Compare
lrazovic
approved these changes
Oct 9, 2024
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 10, 2024 09:37
029390d
to
db429d4
Compare
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
2 times, most recently
from
October 10, 2024 09:39
5e8b4f5
to
3701e31
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 10, 2024 09:43
db429d4
to
85e29bc
Compare
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 10, 2024 09:43
3701e31
to
53d5063
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 10, 2024 09:53
85e29bc
to
3a86fb8
Compare
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 10, 2024 09:53
53d5063
to
b7d6648
Compare
lrazovic
force-pushed
the
09-25-new_e2e_tests
branch
from
October 10, 2024 11:58
3a86fb8
to
9ddd19c
Compare
lrazovic
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 10, 2024 11:58
b7d6648
to
6ac47a9
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 10, 2024 12:00
9ddd19c
to
3a86fb8
Compare
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 10, 2024 12:00
6ac47a9
to
b7d6648
Compare
Merged
lrazovic
force-pushed
the
09-25-new_e2e_tests
branch
from
October 10, 2024 12:20
3a86fb8
to
9ddd19c
Compare
lrazovic
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 10, 2024 12:20
b7d6648
to
6ac47a9
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 10, 2024 12:22
9ddd19c
to
3a86fb8
Compare
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 10, 2024 12:23
6ac47a9
to
b7d6648
Compare
JuaniRios
force-pushed
the
09-25-new_e2e_tests
branch
from
October 10, 2024 13:47
3a86fb8
to
51d58f4
Compare
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 10, 2024 13:47
b7d6648
to
ae385b1
Compare
JuaniRios
changed the base branch from
09-25-new_e2e_tests
to
graphite-base/406
October 10, 2024 14:22
JuaniRios
force-pushed
the
10-04-usdt-fee-pjs-compatibility
branch
from
October 10, 2024 14:24
ae385b1
to
71020d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@polkadot/api
JS packages.Why?
@polkadot/api
JS packages work better if theassetId
is aMultiLocation
/Location
, so our initialu32
based solution didn't workHow?
xcm::v3::MultiLocation
, and convert it internally to au32
.