Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ New e2e tests #405

Merged
merged 1 commit into from
Oct 10, 2024
Merged

✅ New e2e tests #405

merged 1 commit into from
Oct 10, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Sep 30, 2024 •
edited
Loading

What?

Add new e2e tests

Why?

OTM Flow and simplifications were added, so we needed to recheck all the numbers.

How?

Delete everything and start over with this spreadsheet:
https://docs.google.com/spreadsheets/d/1BiKZCf50S9U_jiPPShTqmL6A_DUlFqwx/edit?gid=114355434#gid=114355434

Testing?

Only one test in the e2e.rs file that goes over everything.

Anything Else?

I added a bacon.toml config file. bacon is the successor to cargo watch. Its a program you leave running in the background and dynamically shows you errors from the compiler instead of having to constantly call cargo check or cargo test.

Kind of what rust-analyzer does, but I usually have it disabled because it makes everything mega slow.

This was referenced Sep 30, 2024
Merged
Merged
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Sep 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Sep 30, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-19-otm_funding_tests branch 3 times, most recently from 5115a7b to 990eb8b Compare September 30, 2024 13:14
@JuaniRios JuaniRios changed the title new e2e tests ✅ New e2e tests Sep 30, 2024
@JuaniRios JuaniRios changed the base branch from 09-19-otm_funding_tests to 09-27-test_usdt_transaction_payment October 1, 2024 09:20
@JuaniRios JuaniRios self-assigned this Oct 1, 2024
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch 6 times, most recently from af14208 to 5bc4c91 Compare October 3, 2024 13:03
@JuaniRios JuaniRios marked this pull request as ready for review October 3, 2024 13:06
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 4c8d6cf to f00ff56 Compare October 3, 2024 13:49
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from f00ff56 to 618f4e5 Compare October 3, 2024 14:51
@JuaniRios JuaniRios force-pushed the 09-25-new_e2e_tests branch 2 times, most recently from d1bf42e to d099958 Compare October 4, 2024 09:43
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 6753c44 to 2d14e69 Compare October 9, 2024 09:59
@JuaniRios JuaniRios mentioned this pull request Oct 9, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 2d14e69 to 9b3b6e7 Compare October 10, 2024 09:37
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 9b3b6e7 to a84b5eb Compare October 10, 2024 09:43
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from a84b5eb to 1d2cbe4 Compare October 10, 2024 09:53
@JuaniRios JuaniRios mentioned this pull request Oct 10, 2024
Merged
@lrazovic lrazovic force-pushed the 09-27-test_usdt_transaction_payment branch from 1d2cbe4 to d2bc6b8 Compare October 10, 2024 11:58
@lrazovic lrazovic mentioned this pull request Oct 10, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from d2bc6b8 to 1d2cbe4 Compare October 10, 2024 11:59
@JuaniRios JuaniRios mentioned this pull request Oct 10, 2024
Merged
lrazovic
lrazovic approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Simon and Juan. LGTM

@lrazovic lrazovic force-pushed the 09-27-test_usdt_transaction_payment branch from 1d2cbe4 to d2bc6b8 Compare October 10, 2024 12:20
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from d2bc6b8 to 1d2cbe4 Compare October 10, 2024 12:22
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 1d2cbe4 to 56cd657 Compare October 10, 2024 13:46
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Oct 10, 2024 •
edited
Loading

Merge activity

  • Oct 10, 10:08 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 10:23 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 10, 10:23 AM EDT: A user merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 09-27-test_usdt_transaction_payment to graphite-base/405 October 10, 2024 14:18
@JuaniRios JuaniRios changed the base branch from graphite-base/405 to main October 10, 2024 14:20
@JuaniRios JuaniRios merged commit a301f9e into main Oct 10, 2024
1 check passed
@JuaniRios JuaniRios deleted the 09-25-new_e2e_tests branch October 10, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic