-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GH action warnings #370
Conversation
Thanks @anth-volk! Could you please:
|
Ah, my apologies, I should've reviewed the PR requirements before requesting |
I'm sorry, I'm not understanding the changelog system. I altered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You populated the changelog entry correctly, just this minor change and git pull upstream master
will do it. The action fails if the branch is behind upstream/master.
Co-authored-by: Max Ghenis <[email protected]>
This should now be properly synced with upstream/main and integrate the typographical changes suggested; however, I'm still receiving the same issue when running checks. I'm going to try to dive into this and figure out what it might be. |
It appears that, when forking, Git does not also copy upstream's tags, so after fetching tags from upsteram master, I should now be able to pass the has-functional-changes GitHub workflow |
Sorry @anth-volk - could you re-file from a branch? I just gave you write access- happy to help if unclear |
Actually... this is mergeable- I've just checked the file change. Thanks Anthony! |
Great, thanks! Glad to have finally gotten this one in haha. Thanks for all the support, @nikhilwoodruff and @MaxGhenis. |
Fixes #229
Solution: Upgraded EndBug/add-and-commit, used within push.yml, to version 9, as described in this issue solution within the EndBug/add-and-commit repo.
Version 9 does introduce two breaking changes (described here): the action fails if
git commit
fails, and the action will not attempt to recreate tags when failing to push them. However, it was not possible to test for these two cases.