Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to click and requests + user input in Dockerfile #21

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cgi-ulb
Copy link

@cgi-ulb cgi-ulb commented Jun 21, 2022

No description provided.

@Pold87
Copy link
Owner

Pold87 commented Sep 13, 2022

Thank you for your pull request! I encountered two small issues when testing your version:

  1. The command docker-compose up failed with the error:
ERROR: Service 'academickeywordoccurrence' failed to build: COPY failed: file not found in build context or excluded by .dockerignore: stat poetry.lock: file does not exist
  1. The command python extract_occurrences.py '<keyword>' <start date> <end date> does not work anymore. It will prompt for user input and then fail with Error: Got unexpected extra arguments. Maybe changing option to argument in click would work?

Another thing that I did not check yet in detail is whether quoted strings still work with the command line prompt (e.g. "bitcoin mining").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants