Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add move table for Scarlet/Violet #806

Merged
merged 5 commits into from
Jan 15, 2023
Merged

Conversation

giginet
Copy link
Contributor

@giginet giginet commented Jan 3, 2023

This PR is fixed version of this.
Add move table for Scarlet/Violet by giginet · Pull Request #800 · PokeAPI/pokeapi

I added pokemon_moves table for version_group_id = 25 (Scarlet / Violet)

This table may work for all species and forms in SV.

@Naramsim
Copy link
Member

Hi @giginet , Github says that you've done 35000 additions to the file. Is it right?

@giginet
Copy link
Contributor Author

giginet commented Jan 13, 2023

Yes. This PR contains all SV pokémons and moves matrix. So this have huge diffs.
It’s impossible to be reviewed by hunan eyes. But I tested this data in my product.

@Naramsim
Copy link
Member

ok, I'll build it on my machine

@Naramsim
Copy link
Member

tomorrow

@Naramsim
Copy link
Member

Hi, in the pokemon_moves.csv, level is required. Do you have that info by chance?

@giginet
Copy link
Contributor Author

giginet commented Jan 15, 2023

I filled level only for pokemon_move_method_id = 1 (Level moves)

Do you mean they should be 0 for other move_method moves?
(I think it should be nullable for not Level moves)

I'll fill all columns to 0.

@giginet
Copy link
Contributor Author

giginet commented Jan 15, 2023

I filled all empty level columns to 0 on 1e57075

@Naramsim
Copy link
Member

Perfect! Having 0 is what we have right now for other non-level moves. But I agree, it should be null-able.

@Naramsim Naramsim merged commit e1d2fa8 into PokeAPI:master Jan 15, 2023
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants