Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Scarlet / Violet data for Pokemon Names / Pokemon Forms / Pokemon #793

Merged
merged 14 commits into from
Jan 8, 2023
Merged

Added Scarlet / Violet data for Pokemon Names / Pokemon Forms / Pokemon #793

merged 14 commits into from
Jan 8, 2023

Conversation

giginet
Copy link
Contributor

@giginet giginet commented Dec 9, 2022 •
edited
Loading

I added some info it's proceeded by #778

The form changed Pokémon are not in the current data.

I updated followings:

  • version_groups
  • pokemon
  • pokemon_names (Japanese/English)
  • pokemon_forms
  • pokemon_types
  • pokemon_stats

Some column is missing

  • pokemon.base_experience
  • pokemon_names.genus
  • pokemon_forms/pokemon.order

maiko-ando
maiko-ando reviewed Dec 9, 2022
View reviewed changes
data/v2/csv/pokemon_species_names.csv Outdated
932,1,ミガルーサ,
932,9,Veluza,
932,11,ミガルーサ,
933,1,ナミイカル,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giginet
ポケモン名Typoしてますね

maiko-ando
maiko-ando reviewed Dec 9, 2022
View reviewed changes
data/v2/csv/pokemon_species_names.csv Outdated
964,1,ジオヅム,
964,9,Naclstack,
964,11,ジオヅム,
965,1,キヨジオーン,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giginet
キョジオーン

maiko-ando
maiko-ando reviewed Dec 9, 2022
View reviewed changes
data/v2/csv/pokemon_species_names.csv Outdated
985,1,トドロクツキ,
985,9,Roaring Moon,
985,11,トドロクツキ,
986,1,テツノウダチ,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giginet
テツノワダチ

@giginet
Copy link
Contributor Author

giginet commented Dec 9, 2022

gender_rate was wrong. I‘ll fix this tomorrow

@Naramsim
Copy link
Member

Hi @giginet , thanks for the new data!

Could you also take a look at this: #783 (comment) ?

@giginet
Copy link
Contributor Author

giginet commented Dec 11, 2022

I miss understood, gender_rate is not included in this diff. So this looks good.
Could you review it? @Naramsim

@giginet giginet mentioned this pull request Dec 11, 2022
Merged
Naramsim
Naramsim requested changes Dec 11, 2022
View reviewed changes
data/v2/csv/pokemon.csv Outdated
@@ -904,6 +904,109 @@ id,identifier,species_id,height,weight,base_experience,order,is_default
903,sneasler,903,13,430,,,1
904,overqwil,904,25,605,,,1
905,enamorus-incarnate,905,16,480,,,1
906,sprigatito,906,0.4,4.1,,906,1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, height and weight use decimetres and hectograms. Moreover I don't think we support _floats`. So you just need to multiply the values by 10.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed
b3eebc6

@giginet giginet mentioned this pull request Dec 13, 2022
Merged
@giginet giginet mentioned this pull request Dec 13, 2022
Closed
@oneirocosm
Copy link

oneirocosm commented Jan 2, 2023 •
edited
Loading

I've noticed that the current order of the Paldean species follows the initial data-mined order from Scarlet and Violet. What is the plan for when the official order is eventually released (will probably happen when Pokemon Home updates)? I suppose you could either:

  1. Keep the current order and update the National Dex Numbers in pokemon_dex_numbers.csv
  2. Update the current order to match the official national dex order

If you do go with 2, it may be possible to do some of that work now using the other popular order that I've been seeing lately. There is no guarantee that it will match the official ordering, but I think it is much more likely to based off what I'm reading here and here.

@giginet
Copy link
Contributor Author

giginet commented Jan 3, 2023 •
edited
Loading

@oneirocosm Make sense.
I also worry about current internal data including missing numbers.
I guess this internal numbering might be changed in a future series.
It's important to decide how to number IDs in PokéAPI.

Could somebody consider which way is better?

In the latter way, other following data must be migrated to new IDs.

@Naramsim Naramsim merged commit f050d32 into PokeAPI:master Jan 8, 2023
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@giginet
Copy link
Contributor Author

giginet commented Jan 8, 2023 •
edited
Loading

@Naramsim How do you think about these discussions? #793 (comment)

Should we use current numbering?

@Naramsim
Copy link
Member

Naramsim commented Jan 8, 2023

no clue, I didn't have time to read it. Could you and @oneirocosm decide?

@giginet
Copy link
Contributor Author

giginet commented Jan 9, 2023

@Naramsim Those discussions are important for future compatibilities.
So they should be decided by a core maintainer. We are not maintainers.

If you don't have any concerns, I'll process the following PRs. However, I think it's tough to modify this data structure in the future.

@Naramsim
Copy link
Member

Naramsim commented Jan 9, 2023

What about setting the order as a nullable field and leaving it empty? Until the official numbering is released?

@giginet
Copy link
Contributor Author

giginet commented Jan 10, 2023

Sounds good. I'll use the current numbering for the following PRs.

@giginet giginet deleted the pokemon-forms branch January 10, 2023 07:58
@Naramsim Naramsim mentioned this pull request Jan 12, 2023
Closed
@lordkyuusei
Copy link

lordkyuusei commented Jan 12, 2023 •
edited
Loading

A promotional video came out a few hours ago with what seems like an official ID numbering for each Paldean Pokemon, if it helps confirming the one used currently: https://www.youtube.com/watch?v=pa08Y-fhfTI (starting at 6:36)

@Naramsim
Copy link
Member

yes, other people in another issue are aware of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiko-ando maiko-ando maiko-ando left review comments

@Naramsim Naramsim Awaiting requested review from Naramsim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@giginet @Naramsim @oneirocosm @pokeapi-machine-user @lordkyuusei @maiko-ando