Introduce Scarlet / Violet new items #787
Conversation
data/v2/csv/items.csv
Outdated
| @@ -1606,5 +1606,448 @@ id,identifier,category_id,cost,fling_power,fling_effect_id | |||
| 1656,carrot-seeds,22,20,, | |||
| 1657,ability-patch,26,20,, | |||
| 1658,reins-of-unity,22,0,, | |||
| 1659,adamant-crystal,,,, | |||
There was a problem hiding this comment.
What number of ID should I start from?
Some items are already available since Legends Arceus.
There was a problem hiding this comment.
I think the numbering should be consequent, so it's fine the one used is fine.
There was a problem hiding this comment.
Do you mean, the current numbering doesn't have any problem?
There was a problem hiding this comment.
Hi, yes your numbering is good. Anyways, I'm not sure if we can leave empty the category_id, cost,fling_power and fling_effect_id. Don't you have at least the category_id for your new data.
There was a problem hiding this comment.
There are no original data for category_id so I have to fill this column by hand.
Can we add new item_categories like tm_materials or sandwich_ingredients?
There was a problem hiding this comment.
we can add new categories if needed, yes
|
hi @giginet , thanks a lot for your effort! Could you please take a look at this: #783 (comment) |
|
I'll add |
giginet
force-pushed
the
sv-items
branch
2 times, most recently
from
25d2b45
to
7c7b199
Compare
|
Hi. I added new |
data/v2/csv/items.csv
Outdated
| 1674,big-bamboo-shoot,24,1500,, | ||
| 1675,scroll-of-darkness,21,0,, | ||
| 1676,scroll-of-waters,21,0,, | ||
| 1677,,,,, |
There was a problem hiding this comment.
Is it normal that is all empty?
There was a problem hiding this comment.
I migrated from the original data. It seems to be missing numbers. These columns should be removed.
I'll remove these columns and fill the following IDs.
|
Thanks for the PR, before merging I'd like to have a buildable |
|
Hi @giginet , would it be difficult for you to provide us with the |
|
I don't have any canonical data about costs. The cost column is necessary for merging this? |
|
For us, it would be better to have the cost since right now it's a mandatory field. I can turn it to a |
|
OK. I'll try to fill in all the cost columns in my spare time. Could you review other PRs first? |
|
I'll check out some other PRs :) |
|
Hi @giginet , there's a problem. The For example |
I added a new item since Scarlet / Violet.
All data are migrated from here.
PMSV/Item Names.txt at main · Ruimusume/PMSV
I corrected some Japanese and English names.