Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sprites Submodule So New Sprites Are Reflected In API Responses #768

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

joseph-bayer
Copy link
Contributor

@joseph-bayer joseph-bayer commented Nov 16, 2022

Description

I noticed that a lot of the hard work being done in the pokeapi/sprites repo wasn't showing up in the API responses.

Based on this comment, it seems that this is because the pokeapi sprites submodule needs to point to the newest commit.

Some examples of missing sprite urls in the api responses are the official artwork for Partner Pikachu/Eevee, Eternal Floette, and the various Minior Core colors.

If this isn't the right time to update this or if there's something else I'd need to do to update the sprite urls in the api responses just let me know!

Steps Taken to Update Sprites Submodule

First, I forked the pokeapi repo and then cloned it. Next, I ran the following commands:

git submodule init
git submodule update
git submodule update --remote

Finally, I committed the changes, pushed them and then opened this pull request.

Thanks,
-Joe

@joseph-bayer joseph-bayer changed the title Update sprites submodule to point to the newest commit Update Sprites Submodule So New Sprites Are Reflected In API Responses Nov 16, 2022
@Naramsim Naramsim merged commit 73b9749 into PokeAPI:master Nov 17, 2022
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

O-Tahmas added a commit to O-Tahmas/pokeapi that referenced this pull request May 26, 2024
Removed dupe in locations.csv , malie-city entry PokeAPI#1045 && PokeAPI#768
@O-Tahmas O-Tahmas mentioned this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants