Update Sprites Submodule So New Sprites Are Reflected In API Responses #768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that a lot of the hard work being done in the pokeapi/sprites repo wasn't showing up in the API responses.
Based on this comment, it seems that this is because the pokeapi sprites submodule needs to point to the newest commit.
Some examples of missing sprite urls in the api responses are the official artwork for Partner Pikachu/Eevee, Eternal Floette, and the various Minior Core colors.
If this isn't the right time to update this or if there's something else I'd need to do to update the sprite urls in the api responses just let me know!
Steps Taken to Update Sprites Submodule
First, I forked the pokeapi repo and then cloned it. Next, I ran the following commands:
Finally, I committed the changes, pushed them and then opened this pull request.
Thanks,
-Joe