Enhancement: Updated Sprite URLs returned by API

[LeonEstrak]

Previously the sprite endpoint returned the relative path of
the image with a /media/ prefix which was not useful for API consumer.
Now it returns a URL pointing to the image present in github.com/PokeAPI/Sprites.

Signed-off-by: Aniket Chakraborty [email protected]

[merfed]

Github isn't a CDN, whomever is consuming the API should be hosting the sprites themselves.

[LeonEstrak]

Github isn't a CDN, whomever is consuming the API should be hosting the sprites themselves.

Agreed. But that's when we are trying to scale the project. A lot of the API consumers are people like me making small side projects as a hobby. Besides, the /media/ was not useful in any manner, better to have a usable URL.
And If one wishes to scale, the URL can easily be substituted on the consumer end.

[Naramsim]

Hi @LeonEstrak, I cannot replicate your outcome. When building your branch and applying the metadata. I always get null for the sprite URLs Ok, I didn't clone the sprite submodule. Retrying

[Naramsim]

Cool, it works! Thanks for the PR!

[pokeapi-machine-user]

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.