Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/axios webpack require #61

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

lbineau
Copy link

@lbineau lbineau commented Sep 9, 2024

The previous PR #58 introduced issues with the built file.
This PR aim to fix this issue by changing the webpack target from node to web which was wrongly configured and probably worked because of node polyfill included by default: https://webpack.js.org/blog/2020-10-10-webpack-5-release/#automatic-nodejs-polyfills-removed

I've npm run test and npm run build, and everything seems to work. Then I included the built file locally in an index.html file and no more error are shown.

Error target: 'node'
node target showing a console error: require is undefined

Success target: 'web'
web target showing a console.log success

@lbineau lbineau mentioned this pull request Sep 9, 2024
@Naramsim
Copy link
Member

Hi! Thanks for the pr! Would it be possible to use a beta tag for this release? If we have positive feedback we will promote the code to a normal release

@lbineau
Copy link
Author

lbineau commented Sep 10, 2024

@Naramsim Sure, can you explain me how to do this?

@Naramsim
Copy link
Member

I should be able to do it according to the docs: https://docs.npmjs.com/adding-dist-tags-to-packages

So no action on your side

@Naramsim
Copy link
Member

ok, I think I published the pokeapi-js-wrapper@beta version.

https://www.npmjs.com/package/pokeapi-js-wrapper?activeTab=versions

@isackender , could you try and install that version?

@climaxmba
Copy link
Contributor

ok, I think I published the pokeapi-js-wrapper@beta version.

https://www.npmjs.com/package/pokeapi-js-wrapper?activeTab=versions

@isackender , could you try and install that version?

@Naramsim, I just tried that and it works just fine. Here is a live demo: https://climaxmba.github.io/memory-card/. And the repo: https://github.com/climaxmba/memory-card

@isackender
Copy link

Thanks @lbineau @Naramsim @climaxmba
Version 1.2.6 works perfectly now! :)

Naramsim added a commit that referenced this pull request Sep 13, 2024
@Naramsim Naramsim merged commit 95cc57c into PokeAPI:master Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants