Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

Remove outdated compat entries #97

Merged
merged 3 commits into from
May 14, 2021
Merged

Remove outdated compat entries #97

merged 3 commits into from
May 14, 2021

Conversation

gabrieldansereau
Copy link
Member

@gabrieldansereau gabrieldansereau commented May 13, 2021

What the pull request does

Following #96, I'm testing the compat entries by running the tests locally. The first one I tried, ArchGDAL, had compat entries for which SimpleSDMLayers didn't work.

Edit: Except ArchGDAL, all compat entries worked. I also added a test for density from StatsPlots, and replaced a color so versions of Plots prior to v1.1.0 can also run the tests.

Type of change

Please indicate the relevant option(s)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ❇️ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 This change requires a documentation update

Checklist

  • The changes are documented
    • The docstrings of the different functions describe the arguments, purpose, and behavior
    • There are examples in the documentation website
  • The changes are tested
  • The changes do not modify the behavior of the previously existing functions
    • If they do, please explain why and how in the introduction paragraph
  • For new contributors - my name and information are added to .zenodo.json
  • The Project.toml field version has been updated
    • Change the last number for a v0.0.x series release, a bug fix, or a performance improvement
    • Change the middle number for additional features that do not break the current test suite (unless you fix a bug in the test suite)
    • Change the first number for changes that break the current test suite

I tested ArchGDAL v0.4 and v0.5 (locally) and they are not compatible with the latest features. v0.4 failed multiple times including with SimpleSDMPredictor(WorldClim, BioClim, 1). v0.5 failed with the CHELSA future scenarios, at least.
@gabrieldansereau gabrieldansereau marked this pull request as draft May 13, 2021 20:49
terrain caused problems with versions prior to Plots v1.1.0, which are compatible otherwise
@gabrieldansereau gabrieldansereau marked this pull request as ready for review May 14, 2021 00:50
@gabrieldansereau gabrieldansereau merged commit ba22fed into master May 14, 2021
@gabrieldansereau gabrieldansereau deleted the fix/compat branch May 14, 2021 00:50
gabrieldansereau referenced this pull request May 14, 2021
Add indentation in show method
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant