Various quality of life improvements

[tpoisot]

What the pull request does

• Adds an overload to collect to get the non-nothing values. (Fixes Add a collect or values method #48)
• Adds an overload to isnothing to get the coordinates of nothing values
• Adds an overload to hcat and vcat (Fixes Add hcat and vcat #49)
• Adds a new similar method (Fixes Add a new method to similar #47)
• Adds a mask function to clip a layer using a Boolean layer

Type of change

Please indicate the relevant option(s)

• ❇️ New feature (non-breaking change which adds functionality)
• 📖 This change requires a documentation update

Checklist

• The changes are documented
  • The docstrings of the different functions describe the arguments, purpose, and behavior
  • There are examples in the documentation website
• The changes are tested
• The changes do not modify the behavior of the previously existing functions
• The Project.toml field version has been updated

[codecov-io]

Codecov Report

Merging #50 (f899850) into master (1a41008) will increase coverage by 1.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   85.75%   87.05%   +1.29%     
==========================================
  Files          17       17              
  Lines         344      363      +19     
==========================================
+ Hits          295      316      +21     
+ Misses         49       47       -2     

Flag	Coverage Δ
unittests	87.05% <100.00%> (+1.29%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/datasets/geotiff.jl	100.00% <100.00%> (ø)
src/lib/overloads.jl	94.44% <100.00%> (+4.30%)	⬆️
src/recipes/recipes.jl	88.23% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a41008...8b3df35. Read the comment docs.

[gabrieldansereau]

Love the features! I've played a bit with them on some of my codes and everything seems fine.

Very minor gripe about the isnothing overload however, which I find confusing. I would expect that behaviour with a broadcasted call like isnothing.(layer), not isnothing(layer), since it's operating on the grid elements. Right now it doesn't mimic the same calls made on an Array, as we've done elsewhere. Since it's a bit counterintuitive, I'd just use the one-line call on the grid directly.

Also, you could want to check if a layer is an element of type nothing when calling isnothing(layer), as you can with any other element. But I admit that's not very likely.

So I'm not really opposed to it, I just find it a bit inconsistent and unnecessary.

[tpoisot]

@gabrieldansereau you might be right - I think we can remove it and use an iterator as suggested by @mkborregaard in #51, to do something with findall instead. I should be able to remove it without too much trouble.