Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

Fix CHELSA download url #44

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Fix CHELSA download url #44

merged 2 commits into from
Jan 5, 2021

Conversation

gabrieldansereau
Copy link
Member

@gabrieldansereau gabrieldansereau commented Jan 5, 2021 •
edited
Loading

What the pull request does

Previous tests failed in the test/chelsa.jl script with:

julia> lc1 = bioclim(1; left=-5.0, right=7.0, bottom=30.0, top=45.0)
ERROR: DNSError: envidatrepo.wsl.ch, unknown node or service (EAI_NONAME)

I believe it's because the URL of the CHELSA FTP server has changed from ftp://envidatrepo.wsl.ch to ftp://envicloud.wsl.ch (That's the link on the CHELSA website).
Hopefully this should fix it.

Type of change

Please indicate the relevant option(s)

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Checklist

  • The changes are documented
    • The docstrings of the different functions describe the arguments, purpose, and behavior
    • There are examples in the documentation website
  • The changes are tested
  • The changes do not modify the behavior of the previously existing functions
    • If they do, please explain why and how in the introduction paragraph
  • For new contributors - my name and information are added to .zenodo.json
  • The Project.toml field version has been updated
    • Change the last number for a v0.0.x series release, a bug fix, or a performance improvement
    • Change the middle number for additional features that do not break the current test suite (unless you fix a bug in the test suite)
    • Change the first number for changes that break the current test suite

@gabrieldansereau
Copy link
Member Author

@tpoisot Is there a reason we're using the FTP URL to download the data instead of the HTTPS one?

The tests still failed with FTP, but I've changed it to HTTPS and they now pass (and the CHELSA website recommends HTTPS).
Unless you prefer FTP, I suggest to leave it like this.

Here's the FTP error in case (it's not the same as before). I don't know why the URL is not found, it works to download the files in Firefox.

ERROR: HTTP.ExceptionRequest.StatusError(404, "GET", "/chelsa/chelsa_V1/climatologies/bio/CHELSA_bio10_01.tif", HTTP.Messages.Response:
"""
HTTP/1.1 404 Not Found
Date: Tue, 05 Jan 2021 19:48:34 GMT
Server: Apache/2.4.41 (Ubuntu)
Content-Length: 279
Content-Type: text/html; charset=iso-8859-1

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL was not found on this server.</p>
<hr>
<address>Apache/2.4.41 (Ubuntu) Server at envicloud.wsl.ch Port 443</address>
</body></html>
""")

@gabrieldansereau gabrieldansereau merged commit ab2f257 into master Jan 5, 2021
@gabrieldansereau gabrieldansereau deleted the fix/chelsa-ftp-download branch January 5, 2021 23:02
@gabrieldansereau gabrieldansereau mentioned this pull request Jan 6, 2021
Closed
40 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tpoisot tpoisot Awaiting requested review from tpoisot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gabrieldansereau