This repository has been archived by the owner on Dec 11, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2
Fix cropping when omitting a limit #18
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
089fec5
:bug: fix getindex call when omitting crop limit
gabrieldansereau 43fb3c1
:bug: fix types to omit crop limit
gabrieldansereau 7af8afe
:sparkles: option to crop on NamedTuple
gabrieldansereau f097734
:white_check_mark: test for cropping while omitting limit
gabrieldansereau 5bc369e
Remove the types from the getindex with keywords
tpoisot e19674d
Add a minor version bump
tpoisot df932eb
fix whitespace between function and documentation block
tpoisot b5537f2
preface non-exported functions with _
tpoisot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way to make the types work? They have to be "independent", so that one can be
Nothing
while the others areAbstractFloat
. The previous code only worked if they were allNothing
or allAbstractFloat
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we can always not be specific about the types here, since there is an
isnothing
on one side, and thegetindex
measures do not have methods for anything other than a float in this case... would it fix the tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it already works like this. I was just wondering if there was a cleaner way to call the types.
It works the same if we're not specific about them, as
match_longitude
is specific for floats.