Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

Fix the BRT vignette #128

Merged
merged 4 commits into from
Oct 13, 2021
Merged

Fix the BRT vignette #128

merged 4 commits into from
Oct 13, 2021

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Oct 12, 2021

What the pull request does

The calculation of the adjacency matrix in the BRT vignette was wrong, in a way that gave the right result, but it was still wrong, which is generally regarded as "oof". The PR fixes this.

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📖 This change requires a documentation update

Checklist

  • The Project.toml field version has been updated to v0.8.1

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #128 (e51e606) into main (eb7156d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   58.20%   58.20%           
=======================================
  Files          35       35           
  Lines        1024     1024           
=======================================
  Hits          596      596           
  Misses        428      428           
Flag Coverage Δ
unittests 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7156d...e51e606. Read the comment docs.

@tpoisot
Copy link
Member Author

tpoisot commented Oct 12, 2021

remove whitespace

@tpoisot tpoisot merged commit 4e54da1 into main Oct 13, 2021
@tpoisot tpoisot deleted the tpoisot/issue127 branch April 9, 2022 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant