🔥 remove isnothing to make @gabrieldansereau happy 😄

PoisotLab · Feb 10, 2021 · aa83d19 · aa83d19
1 parent 8b3df35
commit aa83d19
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 13 deletions.
diff --git a/docs/src/man/overloads.md b/docs/src/man/overloads.md
@@ -11,7 +11,6 @@ directly, and also allow to set and get values using the geographic coordinates
 convert
 copy
 collect
-isnothing
 eltype
 size
 stride

diff --git a/src/lib/overloads.jl b/src/lib/overloads.jl
@@ -8,7 +8,6 @@ import Base: copy
 import Base: eltype
 import Base: convert
 import Base: collect
-import Base: isnothing
 import Base.Broadcast: broadcast
 import Base: hcat
 import Base: vcat
@@ -303,16 +302,6 @@ function Base.collect(l::T) where {T <: SimpleSDMLayer}
     return convert(Vector{eltype(l)}, v)    
 end
 
-"""
-    Base.isnothing(l::T) where {T <: SimpleSDMLayer}
-
-Returns a grid the same size as the layer with the positions containing
-`nothing` set to true.
-"""
-function Base.isnothing(l::T) where {T <: SimpleSDMLayer}
-    return isnothing.(l.grid)
-end
-
 """
     Base.vcat(l1::T, l2::T) where {T <: SimpleSDMLayers}
 

diff --git a/src/recipes/recipes.jl b/src/recipes/recipes.jl
@@ -22,7 +22,7 @@ test 2
     seriestype --> :scatter
     if get(plotattributes, :seriestype, :scatter) in [:scatter, :histogram2d]
         SimpleSDMLayers._layers_are_compatible(l1, l2)
-        valid_i = findall(.!isnothing(l1) .& .!isnothing(l2))
+        valid_i = findall(.!isnothing.(l1.grid) .& .!isnothing.(l2.grid))
         l1.grid[valid_i], l2.grid[valid_i]
     end
 end
-Original file line number
+Diff line change
@@ Expand Up @@
     convert
     copy
     collect
-    isnothing
     eltype
     size
     stride
@@ Expand Down @@