🐛 fix geotiff modifying source layer, closes #104

src/datasets/geotiff.jl

@@ -102,11 +102,7 @@ Write a single `layer` to a `file`, where the `nodata` field is set to an
 arbitrary value.
 """
 function geotiff(file::AbstractString, layer::SimpleSDMPredictor{T}; nodata::T=convert(T, -9999)) where {T <: Number}
-    array = layer.grid
-    replace!(array, nothing => NaN)
-    array = convert(Matrix{T}, array)
-    dtype = eltype(array)
-    array_t = reverse(permutedims(array, [2, 1]); dims=2)
+    array_t = _prepare_layer_for_burnin(layer)
     width, height = size(array_t)
 
     # Geotransform
@@ -144,8 +140,7 @@ end
 
 function _prepare_layer_for_burnin(layer::T) where {T <: SimpleSDMLayer}
     @assert eltype(layer) <: Number
-    array = layer.grid
-    replace!(array, nothing => NaN)
+    array = replace(layer.grid, nothing => NaN)
     array = convert(Matrix{eltype(layer)}, array)
     dtype = eltype(array)
     array_t = reverse(permutedims(array, [2, 1]); dims=2)

test/subsetting.jl

@@ -8,11 +8,16 @@ temp = SimpleSDMPredictor(WorldClim, BioClim, 1)
 coords = (left = -145.0, right = -50.0, bottom = 20.0, top = 75.0)
 l1 = temp[coords]
 l2 = SimpleSDMPredictor(WorldClim, BioClim, 1; coords...)
+tempfile = tempname()
+geotiff(tempfile, l2)
+l3 = replace(geotiff(SimpleSDMPredictor, tempfile), NaN => nothing)
 
 @test size(l1) == size(l2)
+@test size(l1) == size(l3)
 @test l1.grid == l2.grid
+@test l1.grid == l3.grid
 
-for l in (l1, l2)
+for l in (l1, l2, l3)
     @test size(l) == (330, 570)
 
     @test l.left == coords.left